patch for inlining all blocks with address taken

Eric Christopher echristo at gmail.com
Wed Apr 23 17:00:05 PDT 2014


A testcase should be easily possible and I'd like to see one before we
approve it :)

-eric

On Wed, Apr 23, 2014 at 12:42 PM, Manman Ren <manman.ren at gmail.com> wrote:
> Hi Gerolf,
>
> The implementation looks good to me, but the testing case will not work
> since r206429 was reverted.
> If it is not possible to come up with a testing case, please try your best
> to explain that in the commit log.
>
> Thanks,
> Manman
>
>
>
> On Thu, Apr 17, 2014 at 2:23 PM, Gerolf Hoflehner <ghoflehner at apple.com>
> wrote:
>>
>> any opinions?
>>
>> On Apr 14, 2014, at 3:29 PM, Gerolf Hoflehner <ghoflehner at apple.com>
>> wrote:
>>
>> > Hi
>> >
>> > In some cases a reference to a cloned block is not available since it
>> > has not been cloned yet. The net effect is that some block may not get
>> > inlined. The attached patch solves this timing problem by first collecting
>> > all candidate inline blocks and computing the references as necessary, and
>> > then proceeding with the actual cloning.
>> >
>> > Gerolf
>> >
>> > <r16427209.patch>_______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list