[PATCH] Integrated assembler. :vararg macro.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Tue Apr 22 07:17:27 PDT 2014


  LGTM with nits.


================
Comment at: test/MC/AsmParser/vararg-default-value.s:17
@@ +16,3 @@
+// CHECK: nop
+.set cc,1
+  ifcc
----------------
cc is never 0 in this test, do you need it?

================
Comment at: test/MC/AsmParser/macros-darwin-vararg.s:7
@@ +6,3 @@
+.macro ifcc arg:vararg
+.if cc
+    \arg
----------------
cc is not needed in this test.


http://reviews.llvm.org/D3354






More information about the llvm-commits mailing list