[PATCH] R600: Make sign_extend_inreg legal.

Tom Stellard tom at stellard.net
Mon Apr 21 06:40:52 PDT 2014


On Thu, Apr 17, 2014 at 10:37:12PM -0700, Matt Arsenault wrote:
> 
> On Apr 2, 2014, at 9:59 AM, Tom Stellard <tom at stellard.net> wrote:
> 
> > I want to move away from using patterns with INSERT_SUBREG, because
> > it just adds another case we need to handle in the SIFixSGPRCopies pass.
> > Can you move this pattern into AMDILISelDAGToDAG.cpp and use REG_SEQUENCE
> > instead of INSERT_SUBREG + IMPLICIT_DEF.
> 
> Now that it handles INSERT_SUBREG anyway, should I go back to using the patterns?
> 

What are the advantages of using the patterns?

-Tom

> -Matt



More information about the llvm-commits mailing list