[PATCH] Allow CMake to build Sphinx documentation

Dan Liew dan at su-root.co.uk
Sun Apr 20 12:14:15 PDT 2014


> SphinxQuickstartTemplate is not the right place for that kind of
> information: one of its goals is getting people to write quality content
> with "as little nonsense as possible". Worrying about a broken link is
> nonsense compared to writing quality content. I would probably be fine with
> a note at the bottom of docs/README.txt.

Okay I'll submit a separate patch for that and CC you.

>>  Would it be worth trying to apply the add_sphinx_target() functin to
>> Clang and lldb as well?
>
>
> Give it a spin on clang as a sanity check (and if you have spare cycles, lld
> too). I don't think lldb uses sphinx. Since this is gated behind an option,
> I wouldn't worry about out-of-tree builds.

I did this and it was necessary to change a few things but it was
pretty straight forward.

> Oh, btw, when I applied your patch last time git gave me some trailing
> whitespace warnings. Please try to avoid trailing whitespace.

Sorry about that. I've just configured vim to highlight trailing
whitespaces so hopefully I'll notice next time.

Thanks,

-- 
Dan Liew
PhD Student - Imperial College London



More information about the llvm-commits mailing list