[llvm] r206643 - OnDiskHashTable: Expect the Info type to declare the offset type

Justin Bogner mail at justinbogner.com
Fri Apr 18 16:56:58 PDT 2014


"Duncan P. N. Exon Smith" <dexonsmith at apple.com> writes:
>> @@ -96,7 +98,7 @@ private:
>>   void resize(size_t NewSize) {
>>     Bucket *NewBuckets = (Bucket *)std::calloc(NewSize, sizeof(Bucket));
>>     // Populate NewBuckets with the old entries.
>> -    for (unsigned I = 0; I < NumBuckets; ++I)
>> +    for (size_t I = 0; I < NumBuckets; ++I)
>
> Should this be offset_type?
>
 ...
>> 
>>     // Emit the payload of the table.
>> -    for (unsigned I = 0; I < NumBuckets; ++I) {
>> +    for (size_t I = 0; I < NumBuckets; ++I) {
>
> Same here?

Yes it should, I don't know what I was thinking. r206672.



More information about the llvm-commits mailing list