[llvm] r206193 - Fix 2008-03-05-SxtInRegBug.ll so that the CHECK-NOT will not match the filename.

Robinson, Paul Paul_Robinson at playstation.sony.com
Fri Apr 18 13:32:33 PDT 2014


> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Nick Lewycky
> Sent: Friday, April 18, 2014 11:36 AM
> To: Reid Kleckner
> Cc: llvm-commits; Richard Trieu
> Subject: Re: [llvm] r206193 - Fix 2008-03-05-SxtInRegBug.ll so that the
> CHECK-NOT will not match the filename.
> 
> Reid Kleckner wrote:
> > On Wed, Apr 16, 2014 at 2:01 AM, Nick Lewycky <nicholas at mxc.ca
> > <mailto:nicholas at mxc.ca>> wrote:
> >
> >     Richard Trieu wrote:
> >
> >         Author: rtrieu
> >         Date: Mon Apr 14 11:53:50 2014
> >         New Revision: 206193
> >
> >         URL: http://llvm.org/viewvc/llvm- project?rev=206193&view=rev
> >         <http://llvm.org/viewvc/llvm-project?rev=206193&view=rev>
> >         Log:
> >         Fix 2008-03-05-SxtInRegBug.ll so that the CHECK-NOT will not
> >         match the filename.
> >
> >         Modified:
> >               llvm/trunk/test/CodeGen/ARM/ 2008-03-05-SxtInRegBug.ll
> >
> >         Modified: llvm/trunk/test/CodeGen/ARM/ 2008-03-05-
> SxtInRegBug.ll
> >         URL: http://llvm.org/viewvc/llvm- project/llvm/trunk/test/
> >         CodeGen/ARM/2008-03-05- SxtInRegBug.ll?rev=206193&r1=
> >         206192&r2=206193&view=diff
> >         <http://llvm.org/viewvc/llvm-
> project/llvm/trunk/test/CodeGen/ARM/2008-03-05-
> SxtInRegBug.ll?rev=206193&r1=206192&r2=206193&view=diff>
> >         ============================== ==============================
> >         ==================
> >         --- llvm/trunk/test/CodeGen/ARM/ 2008-03-05-SxtInRegBug.ll
> >         (original)
> >         +++ llvm/trunk/test/CodeGen/ARM/ 2008-03-05-SxtInRegBug.ll Mon
> >         Apr 14 11:53:50 2014
> >         @@ -14,4 +14,6 @@ bb3:          ; preds = %bb1
> >            }
> >
> >            ; CHECK-NOT: 255
> >         +; CHECK: .file{{.*}}SxtInRegBug.ll
> >
> >
> >     Same suggestion, use "< %s" in the RUN line. And +cc Saleem,
> again.
> >
> >
> > If it's all the same, I much prefer to avoid using < %s.  It makes the
> > failling lit test command copy-pastable, at least in my shell.
> 
> The problem is that something as innocent as renaming a test can cause
> it to change pass/fail. 

Even more innocently, if you are unlucky in your choice of directory
names where you checkout the tree, you can get spurious failures (or
passes, and be unable to repro somebody else's issue).
--the voice of experience

> Similarly adding another testcase to an existing
> test could have very surprising results if you don't pay attention to
> the filename.
> 
> For those reasons we decided long ago that the right style for all tests
> is to use the "< %s" formulation ... but I don't recall anybody bringing
> up the "lit test command copy-pasting" issue back then.
> 
> Nick
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits






More information about the llvm-commits mailing list