[PATCH] Fix bug 19437 - Only add discriminators for DWARF 4 and above.

[Diego Novillo]

On Thu, Apr 17, 2014 at 5:49 PM, Adrian Prantl <aprantl at apple.com> wrote:

>
> On Apr 17, 2014, at 1:12 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
> > Adrian - this disabled discriminators for DWARF < 4, but doesn't
> > disable them for OSX specifically. If OSX is using the default of
> > "current DWARF", it'll need a special case here, right? ("DWARF < 4 ||
> > darwin")
>
> >
> > This change as-is will work for Chromium that uses -gdwarf-2 but might
> > not fix the wider darwin issue.
>
> No I think this is fine. DWARF v2 is the default on Darwin and I won't
> change that until all tools support it. But I'd rather have a way to enable
> the feature for those who want to live on the bleeding edge than disabling
> it completely.
>

So, you want to be able to say:

$ clang -gdwarf-2 -mllvm -force-discriminators

?


I suppose it's doable, but it seems too sharp an edge to provide this. We'd
be explicitly emitting something not supported in dwarf2. Or maybe I'm
missing your point.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140417/09f917d7/attachment.html>