[PATCH] Fix bug 19437 - Only add discriminators for DWARF 4 and above.

[Eric Christopher]

On Thu, Apr 17, 2014 at 1:13 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
> ================
> Comment at: include/llvm/Support/Dwarf.h:957
> @@ +956,3 @@
> +/// Return Dwarf Version by checking module flags.
> +inline unsigned getDwarfVersionFromModule(const Module *M) {
> +  Value *Val = M->getModuleFlag("Dwarf Version");
> ----------------
> Chandler Carruth wrote:
>> David Blaikie wrote:
>> > This might be worth being out of line, maybe. Not a big deal.
>> As Eric was indicating, this can't be in Support. I think this should be a method on Module personally. It needs to be somewhere in the IR library at least.
> Yeah, a method on Module sounds pretty reasonable to me. (it's a bit special case, I wouldn't mind a generic system for retrieving module flags with defaults, but not fussed)
>

*nod* We've talked about this in the past. I still think it's a good idea.

-eric