[PATCH] ARM64: Combine shifts and uses to bit-extract instruction from different basic block

yijiang yjiang at apple.com
Wed Apr 16 09:36:37 PDT 2014


Here is the new patch. More comments are appreciated!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extractbit-v2.patch
Type: application/octet-stream
Size: 21365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140416/76eb75f4/attachment.obj>
-------------- next part --------------

On Apr 16, 2014, at 9:29 AM, Yi Jiang <yjiang at apple.com> wrote:

> You are right. Thank you. 
> On Apr 14, 2014, at 6:59 PM, Matt Arsenault <Matthew.Arsenault at amd.com> wrote:
> 
>> On 04/14/2014 05:25 PM, yijiang wrote:
>>> +  void setHasExtractBitsInsn(bool hasExtractInsn = false) {
>>> +    HasExtractBitsInsn = hasExtractInsn;
>>> +  }
>> The default argument should be true, since that's what all the others do and since the default value is already false
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list