[llvm] r206104 - Add extra checks to mvn.ll test to prevent the "f1" check from matching

Nick Lewycky nicholas at mxc.ca
Wed Apr 16 01:11:33 PDT 2014


Richard Trieu wrote:
> Author: rtrieu
> Date: Fri Apr 11 23:47:04 2014
> New Revision: 206104
>
> URL: http://llvm.org/viewvc/llvm-project?rev=206104&view=rev
> Log:
> Add extra checks to mvn.ll test to prevent the "f1" check from matching
> on a directory name instead of the function name.
>
> Modified:
>      llvm/trunk/test/CodeGen/ARM/mvn.ll
>
> Modified: llvm/trunk/test/CodeGen/ARM/mvn.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/mvn.ll?rev=206104&r1=206103&r2=206104&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/mvn.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/mvn.ll Fri Apr 11 23:47:04 2014
> @@ -73,7 +73,8 @@ entry:
>   	ret i1 %tmp102
>   }
>
> -; CHECK-LABEL: f1
> +; CHECK-LABEL: mvn.ll
> +; CHECK-LABEL: @f1

Counterproposal: remove the "CHECK-LABEL: mvn.ll" by adding < before %s 
in the RUN line? LLC then won't know the input file name and won't print 
it out. That's the way most tests do it.

Also +cc Saleem for removing the < in r205540. Please don't do that.

Nick

>   ; CHECK: mvn
>   ; CHECK: mvn
>   ; CHECK: mvn
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list