[PATCH] InlineFunction doesn't update InlineFunctionInfo with allocas created for byval arguments

Julien Lerouge jlerouge at apple.com
Tue Apr 15 11:12:41 PDT 2014


Thanks, r206307 & r206308.

On Mon, Apr 14, 2014 at 08:34:53PM -0700, Manman Ren wrote:
> LGTM.
> 
> Thanks,
> Manman
> 
> 
> On Mon, Apr 14, 2014 at 11:42 AM, Julien Lerouge <jlerouge at apple.com> wrote:
> 
> >
> >
> >
> > On Fri, Apr 11, 2014 at 12:41:54PM -0700, Manman Ren wrote:
> > > Hi Julien,
> > >
> > > The updated patch looks good overall.
> > > Since there is refactoring going on, can you separate to two patches, one
> > > with refactoring but no functionality change, to make review easier?
> > >
> > > Thanks,
> > > Manman
> > >
> >
> > Hello,
> >
> > Attached inline_001.diff that splits the byval argument initialization,
> > and inline_002.diff that adds the marker for the byval induced allocas
> > and test case.
> >
> > Let me know if there is anything else.
> >
> > Thanks again,
> > Julien
> >
-- 
Julien Lerouge
PGP Key Id: 0xB1964A62
PGP Fingerprint: 392D 4BAD DB8B CE7F 4E5F FA3C 62DB 4AA7 B196 4A62
PGP Public Key from: keyserver.pgp.com



More information about the llvm-commits mailing list