[llvm] r206308 - Add lifetime markers for allocas created to hold byval arguments, make them

[Julien Lerouge]

Author: jlerouge
Date: Tue Apr 15 13:06:46 2014
New Revision: 206308

URL: http://llvm.org/viewvc/llvm-project?rev=206308&view=rev
Log:
Add lifetime markers for allocas created to hold byval arguments, make them
appear in the InlineFunctionInfo.

Added:
    llvm/trunk/test/Transforms/Inline/byval_lifetime.ll
Modified:
    llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp
    llvm/trunk/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll

Modified: llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp?rev=206308&r1=206307&r2=206308&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp Tue Apr 15 13:06:46 2014
@@ -394,6 +394,7 @@ static Value *HandleByValArgument(Value
   
   Value *NewAlloca = new AllocaInst(AggTy, 0, Align, Arg->getName(), 
                                     &*Caller->begin()->begin());
+  IFI.StaticAllocas.push_back(cast<AllocaInst>(NewAlloca));
   
   // Uses of the argument in the function should use our new alloca
   // instead.

Modified: llvm/trunk/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll?rev=206308&r1=206307&r2=206308&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll (original)
+++ llvm/trunk/test/Transforms/Inline/2010-05-31-ByvalTailcall.ll Tue Apr 15 13:06:46 2014
@@ -18,7 +18,8 @@ define void @bar(i32* byval %x) {
 
 define void @foo(i32* %x) {
 ; CHECK-LABEL: define void @foo(
-; CHECK: store i32 %1, i32* %x
+; CHECK: llvm.lifetime.start
+; CHECK: store i32 %2, i32* %x
   call void @bar(i32* byval %x)
   ret void
 }

Added: llvm/trunk/test/Transforms/Inline/byval_lifetime.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Inline/byval_lifetime.ll?rev=206308&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/Inline/byval_lifetime.ll (added)
+++ llvm/trunk/test/Transforms/Inline/byval_lifetime.ll Tue Apr 15 13:06:46 2014
@@ -0,0 +1,26 @@
+; RUN: opt -S -inline < %s | FileCheck %s
+; END.
+
+; By inlining foo, an alloca is created in main to hold the byval argument, so
+; a lifetime marker should be generated as well by default.
+
+%struct.foo = type { i32, [16 x i32] }
+
+ at gFoo = global %struct.foo zeroinitializer, align 8
+
+define i32 @foo(%struct.foo* byval align 8 %f, i32 %a) {
+entry:
+  %a1 = getelementptr inbounds %struct.foo* %f, i32 0, i32 1
+  %arrayidx = getelementptr inbounds [16 x i32]* %a1, i32 0, i32 %a
+  %tmp2 = load i32* %arrayidx, align 1
+  ret i32 %tmp2
+}
+
+define i32 @main(i32 %argc, i8** %argv) {
+; CHECK-LABEL: @main
+; CHECK: llvm.lifetime.start
+; CHECK: memcpy
+entry:
+  %call = call i32 @foo(%struct.foo* byval align 8 @gFoo, i32 %argc)
+  ret i32 %call
+}