[llvm] r206228 - [ARM64][MC] Set the default CPU string to generic.

[Quentin Colombet]

Hi James,

If you look closer, this is a different place than where you added the FIXME.
Indeed, this is the MC layer not the ARM64Subtarget thing.
Therefore, we still have this one to fix and yes, it will trigger tons of file check failures :).

I’ll get into it.

Thanks,
-Quentin

On Apr 15, 2014, at 12:56 AM, James Molloy <james at jamesmolloy.co.uk> wrote:

> Hi Quentin,
> 
> Thanks for doing this. I added the FIXME instead of doing it myself as I was concerned there'd be a ton of filecheck failures from tests that don't specify "darwin" and expect cyclone specific output. Looks like I was mistaken :)
> 
> Cheers,
> 
> James
> 
> 
> On 15 April 2014 01:28, Quentin Colombet <qcolombet at apple.com> wrote:
> Author: qcolombet
> Date: Mon Apr 14 19:28:39 2014
> New Revision: 206228
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=206228&view=rev
> Log:
> [ARM64][MC] Set the default CPU string to generic.
> 
> Modified:
>     llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp
> 
> Modified: llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp?rev=206228&r1=206227&r2=206228&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp (original)
> +++ llvm/trunk/lib/Target/ARM64/MCTargetDesc/ARM64MCTargetDesc.cpp Mon Apr 14 19:28:39 2014
> @@ -44,10 +44,8 @@ static MCSubtargetInfo *createARM64MCSub
>                                                     StringRef FS) {
>    MCSubtargetInfo *X = new MCSubtargetInfo();
> 
> -  // FIXME: Make this darwin-only.
>    if (CPU.empty())
> -    // We default to Cyclone for now, on Darwin.
> -    CPU = "cyclone";
> +    CPU = "generic";
> 
>    InitARM64MCSubtargetInfo(X, TT, CPU, FS);
>    return X;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140415/4a89e890/attachment.html>