[PATCH] ARM64: start porting regression tests from AArch64

Ana Pazos apazos at codeaurora.org
Mon Apr 14 14:08:37 PDT 2014


Hi Tim,

I thought the initial purpose of merging the AArch64 tests to ARM64 was to increase code coverage in ARM64.

We know AArch64 has good coverage because of these regression tests.

During the meetings we had at EuroLLVM a secondary purpose came up which is to catch optimizations that might go into AArch64 and missed from being merged to ARM64.

I am ok with the modifications you made the tests.

Just want to clarify your goals.

Thanks,
Ana.

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: Friday, April 11, 2014 6:10 AM
To: Jiangning Liu
Cc: reviews+D3352+public+224a3f29142be48e at reviews.llvm.org; Ana Pazos; llvm-commits
Subject: Re: [PATCH] ARM64: start porting regression tests from AArch64

> Shouldn't changing 'or' to 'and' in lit config just work? I think you 
> just want to say we need to run the test under AArch64 for both 
> AArch64 and ARM64, right?

It needs both, unfortunately. llvm-lit has no way to know which RUN lines need ARM64 and which need AArch64, so it needs all of them to succeed.

Cheers.

Tim.





More information about the llvm-commits mailing list