[PATCH] Adding diversity for security

Alex Rosenberg alexr at leftfield.org
Mon Apr 14 12:02:13 PDT 2014


I was referring to the call to AtomicIncrement as a way to get a seed for each thread. The threads aren't guaranteed to enter that code in the same order, so there is no guarantee of determinism for a given seed.

Alex

> On Apr 14, 2014, at 10:41 AM, Julian Lettner <julian.lettner at gmail.com> wrote:
> 
> 
>  You are referring to the fact that the RNG instance id is part of the seed, right?
>    Seeds[2] = InstanceID;
> 
>  The initial patch had this so I left it in, but indeed this looks strange from the angle of reproducible builds.
>  I will remove it.
> 
> http://reviews.llvm.org/D1802
> 




More information about the llvm-commits mailing list