[llvm] r205990 - Reimplement debug info compression by compressing the whole section, rather than a fragment.

Eric Christopher echristo at gmail.com
Fri Apr 11 14:59:06 PDT 2014


Looks great, couple of comments:

a) long lines :)
b)

> +  Map.erase(SectionGroupPair(Section->getSectionName(), GroupName));
> +  auto I = Map.insert(std::make_pair(SectionGroupPair(Name, GroupName),
> +                                     Section)).first;
> +  const_cast<MCSectionELF*>(Section)->setSectionName(I->first.first);
> +}
> +
>

Lifetime here is subtle, perhaps a comment that you want the actual string here?

-eric



More information about the llvm-commits mailing list