[PATCH] Debug Info Verifier pass

[Manman Ren]

Hi Duncan,

Thanks for working on this. The patches look great overall.
0001: LGTM
0002: There is some inconsistency in creating debug info verifier pass.
1>
tools/opt/opt.cpp:  if (VerifyEach) PM.add(createVerifierPass());
Should VerifyEach guard debug info verifier as well given that we are using
NoVerify to guard debug info verifier?
I am okay with not using VerifyEach for debug info verifier, but please add
comments there to explain why.

2> What about these two places? Should we add debug info verifier?
tools/clang/lib/CodeGen/BackendUtil.cpp:    FPM->add(createVerifierPass());
unittests/Bitcode/BitReaderTest.cpp:  passes.add(createVerifierPass());

3> Could you turn debug info verifier on by default and make sure it is
working correctly with "make check-all"?

Thanks,
Manman


On Mon, Apr 7, 2014 at 2:32 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> Eric and Manman,
>
> Picking up from the llvmdev discussion in December [1], here's a
> stab at DebugInfoVerifier:
>
>   - Splits out supporting functionality from Verifier into
>     VerifierSupport.
>
>   - Adds LegacyDebugInfoVerifierPassPass, a ModulePass which wraps
>     DebugInfoVerifier.  Uses -verify-di command-line flag.
>
>   - Change verifyModule() to invoke DebugInfoVerifier as well as
>     Verifier.
>
>   - Add a call to createDebugInfoVerifierPass() wherever there was a
>     call to createVerifierPass().
>
> Is this what you two were thinking of, or have I gone off course?
>
> Thanks,
> Duncan
>
> [1]: http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-December/068870.html
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140411/d16570f5/attachment.html>