[PATCH] ARM64: start porting regression tests from AArch64

Tim Northover t.p.northover at gmail.com
Fri Apr 11 04:45:40 PDT 2014


Hi apazos,

Hi all,

This is the start of my work to make sure all AArch64 regression tests pass on the ARM64 backend as well.

In the end, I decided that it would be best to modify the existing AArch64 tests rather than create duplicates in the ARM64 directory.

This has the advantage that they're guaranteed to stay in sync: if someone adds a new feature to AArch64 that isn't in ARM64, the test will start failing and some action must be taken. I suggest adding the feature if possible, or creating bugzilla report if necessary and putting a hack in the test.

The disadvantage is that anyone building Clang with *just* AArch64 enabled (not ARM64) will get less test coverage (none of lib/CodeGen/AArch64 will run for that compiler). This is a fairly large disadvantage in those situations, so I'd understand if this is unacceptable to some users.

What's the feeling on this approach?

Cheers.

Tim.



http://reviews.llvm.org/D3352

Files:
  test/CodeGen/AArch64/128bit_load_store.ll
  test/CodeGen/AArch64/adc.ll
  test/CodeGen/AArch64/addsub.ll
  test/CodeGen/AArch64/lit.local.cfg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3352.1.patch
Type: text/x-patch
Size: 5443 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140411/d7454870/attachment.bin>


More information about the llvm-commits mailing list