[PATCH] Remove NamedMDNode::dump

Robert Matusewicz matekm at gmail.com
Mon Apr 7 10:01:50 PDT 2014


Comment for this method inform that it was created for "Allow printing of NamedMDNodes from the debugger", but it is not used anywhere and can be removed. (just to clean public interface of NamedMDNode).

http://reviews.llvm.org/D3310

Files:
  include/llvm/IR/Metadata.h
  lib/IR/AsmWriter.cpp

Index: include/llvm/IR/Metadata.h
===================================================================
--- include/llvm/IR/Metadata.h
+++ include/llvm/IR/Metadata.h
@@ -274,9 +274,6 @@
   /// print - Implement operator<< on NamedMDNode.
   void print(raw_ostream &ROS, AssemblyAnnotationWriter *AAW = 0) const;
 
-  /// dump() - Allow printing of NamedMDNodes from the debugger.
-  void dump() const;
-
   // ---------------------------------------------------------------------------
   // Operand Iterator interface...
   //
Index: lib/IR/AsmWriter.cpp
===================================================================
--- lib/IR/AsmWriter.cpp
+++ lib/IR/AsmWriter.cpp
@@ -2252,5 +2252,3 @@
 // Module::dump() - Allow printing of Modules from the debugger.
 void Module::dump() const { print(dbgs(), 0); }
 
-// NamedMDNode::dump() - Allow printing of NamedMDNodes from the debugger.
-void NamedMDNode::dump() const { print(dbgs(), 0); }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D3310.1.patch
Type: text/x-patch
Size: 941 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140407/d1b49f86/attachment.bin>


More information about the llvm-commits mailing list