[PATCH] [Instcombine] Recognize test for overflow in integer multiplication.

[Serge Pavlov]

2014-04-06 20:32 GMT+07:00 Erik Verbruggen <erik.verbruggen at me.com>:

>
>   Could you rename the method to ProcessUMulZExtIdiom? The
> ProcessUAddIdiom handles a different case, and I have a patch that does the
> same for UMul.
>
>   Otherwise, LGTM, but bkramer has the final say.
>

Thank you for review. I updated fix in phabricator. Waiting for bkramer's
word.


>
>   As a follow-up, are you interested in doing the same for a signed sub
> and mul? (Add is already handled.) If not, I can do that.
>
>
Yes, please do that. I took these old problem in hope I wouldn't interfere
with anybody. I am sorry I hindered you.


> http://reviews.llvm.org/D2814
>
>
>


-- 
Thanks,
--Serge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140407/1d2aeff8/attachment.html>