[patch, darwin-legacy] suppressing OS version asm directive

Jim Grosbach grosbach at apple.com
Thu Apr 3 16:24:33 PDT 2014


Hi David,

I think we’re going to have to be a little more clever here. The intent of these directives is to enable better build time diagnostics when mixing and matching deployment targets that are older than the tools being used. Perhaps we could disable if the target is ppc*-apple-darwin instead?

-Jim

On Mar 27, 2014, at 4:56 PM, David Fang <fang at csl.cornell.edu> wrote:

> Hi Jim,
> 	A few weeks ago, you alerted us darwin-legacy users that r204190 and r204191 added a new asm directive that would break compatibility with older cctools.  My regression testing found that test/CodeGen/PowerPC/hello-reloc.ll had failed due to different macho-dump, for instance. I took a stab at the attached patch to suppress this new directive (guessing that OS X 10.9 is the cut-off).  The patch restores my regression tests to their previous state.  Does this seem like an adequate workaround for legacy support?
> 
> David
> 
> -- 
> David Fang
> http://www.csl.cornell.edu/~fang/
> <llvm-suppress-osversion-asm-directive.patch>





More information about the llvm-commits mailing list