[lld] r205578 - Minor cleanups.

Rui Ueyama ruiu at google.com
Thu Apr 3 15:43:42 PDT 2014


Author: ruiu
Date: Thu Apr  3 17:43:42 2014
New Revision: 205578

URL: http://llvm.org/viewvc/llvm-project?rev=205578&view=rev
Log:
Minor cleanups.

Modified:
    lld/trunk/lib/Core/Resolver.cpp
    lld/trunk/lib/Core/SymbolTable.cpp

Modified: lld/trunk/lib/Core/Resolver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=205578&r1=205577&r2=205578&view=diff
==============================================================================
--- lld/trunk/lib/Core/Resolver.cpp (original)
+++ lld/trunk/lib/Core/Resolver.cpp Thu Apr  3 17:43:42 2014
@@ -198,14 +198,9 @@ void Resolver::doDefinedAtom(const Defin
                     << "\n");
 
   // Verify on zero-size atoms are pinned to start or end of section.
-  switch (atom.sectionPosition()) {
-  case DefinedAtom::sectionPositionStart:
-  case DefinedAtom::sectionPositionEnd:
+  if (atom.sectionPosition() == DefinedAtom::sectionPositionStart ||
+      atom.sectionPosition() == DefinedAtom::sectionPositionEnd) {
     assert(atom.size() == 0);
-    break;
-  case DefinedAtom::sectionPositionEarly:
-  case DefinedAtom::sectionPositionAny:
-    break;
   }
 
   // add to list of known atoms

Modified: lld/trunk/lib/Core/SymbolTable.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/SymbolTable.cpp?rev=205578&r1=205577&r2=205578&view=diff
==============================================================================
--- lld/trunk/lib/Core/SymbolTable.cpp (original)
+++ lld/trunk/lib/Core/SymbolTable.cpp Thu Apr  3 17:43:42 2014
@@ -367,10 +367,9 @@ const Atom *SymbolTable::findByName(Stri
 }
 
 bool SymbolTable::isDefined(StringRef sym) {
-  const Atom *atom = findByName(sym);
-  if (atom == nullptr)
-    return false;
-  return atom->definition() != Atom::definitionUndefined;
+  if (const Atom *atom = findByName(sym))
+    return atom->definition() != Atom::definitionUndefined;
+  return false;
 }
 
 void SymbolTable::addReplacement(const Atom *replaced,





More information about the llvm-commits mailing list