[PATCH] XCore target: Add TypeString meta data to IR output.

[Eric Christopher]

  Some more inline comments...


================
Comment at: lib/CodeGen/TargetInfo.cpp:6086
@@ +6085,3 @@
+  unsigned IncompleteUsedCount;
+public:
+  void AddIncomplete(const IdentifierInfo *ID, std::string& Temp);
----------------
Coding style here (and elsewhere):

http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly

================
Comment at: lib/CodeGen/TargetInfo.cpp:6230
@@ +6229,3 @@
+/// The TypeString carries type, qualifier, name, size & value details.
+/// Please see 'Tools Developement Guide' section 2.16.2 for format details:
+/// <https://www.xmos.com/download/public/Tools-Development-Guide%28X9114A%29.pdf>
----------------
I'd say that since this is an odd vendor thing that we might want to just include the format in the text that describes it?

On the other hand if xmos isn't in business anymore we could just delete the port immediately for lack of documentation? :)


http://llvm-reviews.chandlerc.com/D2929