[llvm] r199244 - Reapply "LTO: add API to set strategy for -internalize"

Eric Christopher echristo at gmail.com
Wed Apr 2 15:20:52 PDT 2014


On Wed, Apr 2, 2014 at 3:18 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>
> On Apr 2, 2014, at 14:35, Eric Christopher <echristo at gmail.com> wrote:
>
>> Also I didn't see an ACK from anyone in the thread there on the
>> expansion of the API. I could be missing it though.
>
> I took the LGTMs from Nick and Justin as ACK enough; it's clear now I
> should have waited for an explicit API review as well.  Fortunately,
> Rafael caught it before the release made it "permanent".

Yeah, I didn't see Justin's reply in the thread and we really do try
to add things to the C API as little as possible :)

-eric



More information about the llvm-commits mailing list