[PATCH] Use cast<T> for type conversion with assertion.

Rui Ueyama ruiu at google.com
Wed Apr 2 15:16:46 PDT 2014


For such internal errors, we are simply using cast<T> (or even unchecked
dyn_cast<T> which is not a very safe practice), and I don't think we want
to add a friendly assertion error message for each cast<T>, so it seems
having friendly message only here is a bit weird. That being said, I'm ok
to keep this if you still don't like it as this is not an important point.


On Wed, Apr 2, 2014 at 3:06 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

>
>   The cause could only be due to a bad reader, and could catch cases when
> the Reader creates bad references to atoms.
>
> http://llvm-reviews.chandlerc.com/D3269
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140402/4ac71e91/attachment.html>


More information about the llvm-commits mailing list