[PATCH] Add ARM big endian Target (armeb, thumbeb)

Christian Pirker cpirker at a-bix.com
Wed Apr 2 08:21:30 PDT 2014


  Hi Tim,

  The comment at line "ARMAsmBackend.cpp:719" is committed in r205215.
  The comment at line "ARMAsmBackend.cpp:790" is patched and committed in D3228.

  There is no explicit test case for the getFixupKindContainerSizeBytes, but e.g. for function calls this function is relevant and implicit test cases are available.

  Thanks,
  Christian


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:105
@@ -103,1 +104,3 @@
     };
+    const static MCFixupKindInfo InfosBE[ARM::NumTargetFixupKinds] = {
+// This table *must* be in the order that the fixup_* kinds are defined in
----------------
Tim Northover wrote:
> I also suspect this extra table isn't needed. ARM doesn't make use of the actual offset & size entries, leaving only a cosmetic effect on some of the comments output by llvm-mc.
> 
> It also has incorrect entries, even if it should exist (e.g. fixup_t2_movt_hi16 -- the 'i' bit, beyond 20, is affected by the fixup).
This table has just been cloned for consistency with the little endian target with corresponding functionality for the big endian target.



http://llvm-reviews.chandlerc.com/D3095



More information about the llvm-commits mailing list