[PATCH] ARM: Windows on ARM Hazard recognition support

Renato Golin renato.golin at linaro.org
Wed Apr 2 02:37:04 PDT 2014


  Hi Saleem,

  Apart from my feature flag comment, looks good. Though, I don't know the Windows ABI that well, you may wait for more specific comments.

  cheers,
  --renato


================
Comment at: lib/Target/ARM/ARMHazardRecognizer.cpp:69
@@ +68,3 @@
+  const Triple TT(MI->getParent()->getParent()->getTarget().getTargetTriple());
+  if (TT.isOSWindows()) {
+    if (LastMI && LastMI->getOpcode() == ARM::t2MOVi16 &&
----------------
Maybe we should set a feature flag for this somewhere a bit lower, and mark it true on Windows triples?


http://llvm-reviews.chandlerc.com/D3254



More information about the llvm-commits mailing list