[lld] r205399 - Devirtualize Resolver.

Rui Ueyama ruiu at google.com
Tue Apr 1 23:18:12 PDT 2014


Author: ruiu
Date: Wed Apr  2 01:18:12 2014
New Revision: 205399

URL: http://llvm.org/viewvc/llvm-project?rev=205399&view=rev
Log:
Devirtualize Resolver.

No one inherits Resolver. Virtualizing the member functions was just
making it inefficient.

Modified:
    lld/trunk/include/lld/Core/Resolver.h

Modified: lld/trunk/include/lld/Core/Resolver.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Resolver.h?rev=205399&r1=205398&r2=205399&view=diff
==============================================================================
--- lld/trunk/include/lld/Core/Resolver.h (original)
+++ lld/trunk/include/lld/Core/Resolver.h Wed Apr  2 01:18:12 2014
@@ -40,23 +40,21 @@ public:
       : _context(context), _symbolTable(context), _result(new MergedFile()),
         _haveLLVMObjs(false), _addToFinalSection(false) {}
 
-  virtual ~Resolver() {}
-
   // InputFiles::Handler methods
-  virtual void doDefinedAtom(const DefinedAtom&);
-  virtual void doUndefinedAtom(const UndefinedAtom&);
-  virtual void doSharedLibraryAtom(const SharedLibraryAtom &);
-  virtual void doAbsoluteAtom(const AbsoluteAtom &);
+  void doDefinedAtom(const DefinedAtom&);
+  void doUndefinedAtom(const UndefinedAtom&);
+  void doSharedLibraryAtom(const SharedLibraryAtom &);
+  void doAbsoluteAtom(const AbsoluteAtom &);
 
   // Handle files, this adds atoms from the current file thats
   // being processed by the resolver
-  virtual void handleFile(const File &);
+  void handleFile(const File &);
 
   // Handle an archive library file.
-  virtual void handleArchiveFile(const File &);
+  void handleArchiveFile(const File &);
 
   // Handle a shared library file.
-  virtual void handleSharedLibrary(const File &);
+  void handleSharedLibrary(const File &);
 
   /// @brief do work of merging and resolving and return list
   bool resolve();





More information about the llvm-commits mailing list