[PATCH] Move nextFile() from LinkingContext to InputGraph.

Shankar Easwaran shankare at codeaurora.org
Tue Apr 1 21:05:00 PDT 2014


LGTM.

On 4/1/2014 10:27 PM, Rui Ueyama wrote:
> Hi Bigcheese, shankarke, kledzik,
>
> LinkingContext and InputGraph are unnecessarily entangled. Most linker
> input file data, e.g. the vector containing input files, the next index
> of the input file, etc. are managed by InputGraph, but only the current
> input file is for no obvious reason managed by LinkingContext.
>
> This patch is to move code from LinkingContext to InputGraph to fix it.
> It's now clear who's reponsible for managing input file state, which is
> InputGraph, and LinkingContext is now free from that responsibility.
> It improves the readability as we now have fewer dependencies between
> classes. No functionality change.
>
> http://llvm-reviews.chandlerc.com/D3259
>
> Files:
>    include/lld/Core/InputGraph.h
>    include/lld/Core/LinkingContext.h
>    lib/Core/InputGraph.cpp
>    lib/Core/LinkingContext.cpp
>    lib/Core/Resolver.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140401/694e3baf/attachment.html>


More information about the llvm-commits mailing list