[PATCH] Greatly simplify InputGraph.

[Rui Ueyama]

================
Comment at: include/lld/Core/InputGraph.h:86
@@ -85,3 @@
-  /// \brief Validate the input graph
-  virtual bool validate();
-
----------------
Shankar Kalpathi Easwaran wrote:
> This is very essential for validating the graph. Currently we dont have code to validate but essentially a place holder to validate command line options.
It's odd that a very essential method is at the same time just a placeholder... We could add it when you need it.

================
Comment at: include/lld/Core/InputGraph.h:186-188
@@ -185,5 +159,1 @@
 
-  /// \brief Is this a hidden node, hidden nodes are not part of
-  /// of the resolver.
-  virtual bool isHidden() const { return false; }
-
----------------
Shankar Kalpathi Easwaran wrote:
> why is this removed ? The linker script node is a hidden node, thats not used by the resolver, and has to be skipped. We have unit tests that capture it (InputGraphTest in unittests).
It's removed because doing it is safe. normalize() always remove a node if it's expanded. LinkerScript node is be expanded and removed from an InputGraph, so no need to skip it in Resolver.


http://llvm-reviews.chandlerc.com/D3252

BRANCH
  cleanup

ARCANIST PROJECT
  lld