[llvm] r205277 - Add a comment about type-uniquing ObjC types.

[Eric Christopher]

On Mon, Mar 31, 2014 at 8:41 PM, Adrian Prantl <aprantl at apple.com> wrote:
> Author: adrian
> Date: Mon Mar 31 22:40:59 2014
> New Revision: 205277
>
> URL: http://llvm.org/viewvc/llvm-project?rev=205277&view=rev
> Log:
> Add a comment about type-uniquing ObjC types.
>
> Modified:
>     llvm/trunk/include/llvm/IR/DebugInfo.h
>
> Modified: llvm/trunk/include/llvm/IR/DebugInfo.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DebugInfo.h?rev=205277&r1=205276&r2=205277&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/IR/DebugInfo.h (original)
> +++ llvm/trunk/include/llvm/IR/DebugInfo.h Mon Mar 31 22:40:59 2014
> @@ -767,6 +767,8 @@ public:
>      return (getUnsignedField(6) & dwarf::DW_APPLE_PROPERTY_nonatomic) != 0;
>    }
>
> +  /// Objective-C doesn't have an ODR, so there is no benefit in storing
> +  /// the type as a DITypeRef here.

Any reason not to though? I'm envisioning something like the same
archive being lto'd twice via two things, etc. You'd want to be able
to unique it I'd think. It's a bit of a stretch I understand, but the
uniformity might be nice.

-eric

>    DIType getType() const { return getFieldAs<DIType>(7); }
>
>    /// Verify - Verify that a derived type descriptor is well formed.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits