[PATCH] Fixing ARM64 warnings

Aaron Ballman aaron at aaronballman.com
Mon Mar 31 14:50:02 PDT 2014


This patch is a conglomerate attempt to silence about MSVC 300
warnings in the new ARM64 backend. Since I don't usually work in the
backends, and some of this was relatively confusing code to begin
with, I figured I'd get a review on my attempted fixes.

ARM64AsmParser.cpp changes are especially questionable -- the return
type is bool, but it's returning an enumeration value which is
definitely not false. And in the case of
ARM64AsmParser::parseVectorList, the function never returns true.

Thanks!

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ARM64Warnings.patch
Type: application/octet-stream
Size: 6716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140331/68ef6bd8/attachment.obj>


More information about the llvm-commits mailing list