[lld] r205163 - [core] support .gnu.linkonce sections

[Rui Ueyama]

On Mon, Mar 31, 2014 at 12:23 PM, Shankar Easwaran
<shankare at codeaurora.org>wrote:

> On 3/31/2014 2:11 PM, Rui Ueyama wrote:
>
>> I'm not sure if you get my suggestion. This suggestion is basically to
>> keep your code as is, except that replacing conditions inside if's with
>> atom->isComdatGroup(). That would look better than writing the same
>> conditions in many places. We already have a precedence of a utility method
>> that is to be used inside a if condition, which is DefinedAtom::
>> occupiesDiskSpace().
>>
> Ah!!! Again, .gnu.linkonce doesnot call for itself a comdatGroup,
> developers might get a wrong impression of calling .gnu.linkonce for a
> COMDAT group.


Then, how about isComdatGroupSematics or something like that?


>
> Thanks
>
> Shankar Easwaran
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by the Linux Foundation
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140331/d7a0352b/attachment.html>