[lld] r205163 - [core] support .gnu.linkonce sections

[Shankar Easwaran]

On 3/31/2014 11:47 AM, Rui Ueyama wrote:
> On Mon, Mar 31, 2014 at 9:27 AM, Shankar Easwaran
> <shankare at codeaurora.org>wrote:
>
>> On 3/30/2014 11:11 PM, Rui Ueyama wrote:
>>
>>> This is not an obvious change to Core, not suitable for post-commit
>>> review.
>>> Please roll it back until we reach a conclusion that this is the right
>>> design.
>>>
>>>   I am not sure why its not a change, that has to be present in core. See
>> my notes below.
>
> I don't get it. What do you mean?
>
> Anyways, 1) this change is to a common component of LLD shared by all
> ports, 2) made everybody writing code for COMDAT to check gnu.linkonce too,
> and 3) was not discussed if that is the right design. If this repository is
> owned by you that's fine but this is a shared repository. Please follow the
> rule.
I dont have any issues. with reverting this patch for now, but there is 
no need to send an email like this.

I raised my opinion on why I chose this design, and I see contributing 
inputs to a better design might have been much more useful.
This is what I see mostly in open source development.

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation