[llvm] r205124 - X86Subtarget.h: isTargetWindows() should tell whether he is targeting msvc.

NAKAMURA Takumi geek4civic at gmail.com
Sat Mar 29 21:35:00 PDT 2014


Author: chapuni
Date: Sat Mar 29 23:35:00 2014
New Revision: 205124

URL: http://llvm.org/viewvc/llvm-project?rev=205124&view=rev
Log:
X86Subtarget.h: isTargetWindows() should tell whether he is targeting msvc.

FYI, !isWindowsGNUEnvironment() is insufficient. It missed cygwin.

FIXME: The name "isTargetWindows" should be fixed.

Modified:
    llvm/trunk/lib/Target/X86/X86Subtarget.h

Modified: llvm/trunk/lib/Target/X86/X86Subtarget.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.h?rev=205124&r1=205123&r2=205124&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86Subtarget.h (original)
+++ llvm/trunk/lib/Target/X86/X86Subtarget.h Sat Mar 29 23:35:00 2014
@@ -344,8 +344,7 @@ public:
   bool isTargetNaCl32() const { return isTargetNaCl() && !is64Bit(); }
   bool isTargetNaCl64() const { return isTargetNaCl() && is64Bit(); }
   bool isTargetWindows() const {
-    return TargetTriple.isOSWindows() &&
-           !TargetTriple.isWindowsGNUEnvironment();
+    return TargetTriple.isKnownWindowsMSVCEnvironment();
   }
   bool isTargetMingw() const { return TargetTriple.isWindowsGNUEnvironment(); }
   bool isTargetCygwin() const {





More information about the llvm-commits mailing list