[PATCH] Missing break

Rafael Espíndola rafael.espindola at gmail.com
Sat Mar 29 20:33:55 PDT 2014


On 8 March 2014 16:57, Tobias G√ľntner
<guentner at rbg.informatik.tu-darmstadt.de> wrote:
> Hi!
>
> Am 08.03.2014 19:32, schrieb Tim Northover:
>
>> Both changes look obviously right, but the first one looks like it
>> should be testable somehow. Presumably you found it when the current
>> behaviour caused you problems. Do you have (or can you make) some
>> small code snippet that could be added to our tests?
>
>
> I'm afraid not. I was just browsing through the code, looking for something
> else, when I noticed a fall-through without a comment.

It does seem hard to test.

I have committed the patches as r205121 and r205119.

Cheers,
Rafael




More information about the llvm-commits mailing list