[PATCH] Fix to support properly cleaning up failed address sinking against constants

Louis Gerbarg lgg at apple.com
Fri Mar 28 19:01:37 PDT 2014


It turns out there is an edge case where the cleanup code for I introduced in r204833 can cause a crash if the address we attempted to sink and then backed out was coming from a constant. This patch changes the check used to determine if cleaning up the IR is necessary to use a dyn_cast and confirm it is in fact an instruction and not a constant.

Louis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-to-support-properly-cleaning-up-failed-address-s.patch
Type: application/octet-stream
Size: 1400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140328/7741d50d/attachment.obj>


More information about the llvm-commits mailing list