[PATCH] Extend SLPVectorizer for cases where insertelement instructions must be rescheduled
arch.robison at intel.com
Fri Mar 28 08:47:01 PDT 2014
Yes, that looks much better.
I suggest making the attribution "Patch by Arch Robison and Arnold Schwaighofer." since it's a significant improvement to my proposed patch. There is only one n in my last name.
Thanks to both of you for all the help.
- Arch Robison
From: Nadav Rotem [mailto:nrotem at apple.com]
Sent: Friday, March 28, 2014 1:46 AM
To: Arnold Schwaighofer
Cc: Robison, Arch; Commit Messages and Patches for LLVM
Subject: Re: [PATCH] Extend SLPVectorizer for cases where insertelement instructions must be rescheduled
On Mar 27, 2014, at 9:55 PM, Arnold Schwaighofer <aschwaighofer at apple.com> wrote:
> How about we simplify the logic in BoUpSLP by sinking the logic for handling the "BuildVector" into the SLPVectorizer like in the attached patch?
> This reduces the interface of BoUpSLP to just a "UserIgnoreList" that is used when checking scheduling and generation of extracts for out of tree users.
> Nadav, is this in the spirit of what you meant today?
Arnold, I really like your approach. Thanks!
> On Mar 27, 2014, at 10:38 AM, Arch D. Robison <arch.robison at intel.com> wrote:
>> Thanks for the suggestions. the find-->count change will eliminate the long line issue :-)
>> I didn't understand the suggestion of changing:
>> Aren't these different? I couldn't find a "moveAfter" method.
More information about the llvm-commits