[PATCH] Add ARM big endian Target (armeb, thumbeb)

Christian Pirker cpirker at a-bix.com
Fri Mar 28 07:55:03 PDT 2014


  I committed this patch as r205007.


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:648
@@ +647,3 @@
+
+  case FK_Data_1:
+  case ARM::fixup_arm_thumb_bcc:
----------------
Tim Northover wrote:
> Why does FK_Data_1 have 2 bytes fixup? If it's not a straight typo, it might be pointing at a bigger abuse in existing code.
This function returns the full instruction size of the fixed-up instruction, and is not the number of bytes to fixup.
It will be used in the next context below (line 700) to calculate the index of the changed byte.



http://llvm-reviews.chandlerc.com/D3095



More information about the llvm-commits mailing list