[PATCH] CMake: Add ability to disable building LLVM utils

Reid Kleckner rnk at google.com
Thu Mar 27 19:31:38 PDT 2014


Patch LGTM.

Should we nuke FileUpdate?  It looks like it was added in 2009 / r77954,
and it hasn't been used since then.  All the other commits are updates for
lib/Support changes. CMake already has a solution to the problem it's
trying to solve, and we're trying to standardize on the CMake build and
kill the autoconf build.


On Thu, Mar 27, 2014 at 10:34 AM, Chris Bieneman <cbieneman at apple.com>wrote:

> There is an LLVM_INSTALL_TOOLCHAIN_ONLY option which adds only the
> toolchain tools to the install list, but you still end up building the
> non-toolchain tools and utils. I could rework the patch to instead be
> LLVM_BUILD_TOOLCHIAN_ONLY if that is a preferable route.
>
> -Chris
>
> On Mar 26, 2014, at 10:08 PM, Reid Kleckner <rnk at google.com> wrote:
>
> Don't we already have functionality for this?  LLVM_BUILD_TOOLCHAIN_ONLY
> or something like that?  Can we extend that with various levels instead?
>
>
> On Wed, Mar 26, 2014 at 8:07 PM, Chris Bieneman <cbieneman at apple.com>wrote:
>
>> For shipping products that include llvm libraries and tools we want the
>> ability to not build some of the LLVM utilities (FileCheck, FileUpdate,
>> count, not, llvm-lit, and yaml-bench).
>>
>> This patch accomplishes this by adding a new CMake option
>> LLVM_INCLUDE_UTILS which excludes those subdirectories. This patch also
>> adds an error if you set LLVM_INCLUDE_UTILS to OFF while setting
>> LLVM_INCLUDE_TESTS to ON, because including tests necessitates including
>> the utils.
>>
>> -Chris
>>
>> Files:
>>   CMakelists.txt
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140327/7fdf21a3/attachment.html>


More information about the llvm-commits mailing list