[llvm] r204901 - Rejected r204899 and r204900 due to remaining test failures on cmake-llvm-x86_64-linux buildbot.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Mar 27 14:00:04 PDT 2014

> Rafael,
> One thing that was raised is that the fixup might not be the best
> solution for the problem. A better way would be to wait until all
> symbols were resolved to apply compile-time constant arithmetic. If
> that's not possible, than bail out.

That is what a fixup is :-)

  if (!evaluateFixup(Layout, Fixup, &F, Target, FixedValue)) {
    // The fixup was unresolved, we need a relocation. Inform the object
    // writer of the relocation, and give it an opportunity to adjust the
    // fixup value if need be.
    getWriter().RecordRelocation(*this, Layout, &F, Fixup, Target, FixedValue);

We try to fold constants early too for cases where that is possible as
an optimization.


More information about the llvm-commits mailing list