[PATCH] Do not use layout-before to layout atoms.

Shankar Easwaran shankare at codeaurora.org
Thu Mar 27 12:45:08 PDT 2014


On 3/27/2014 2:33 PM, Rui Ueyama wrote:
> (I accidentally hit "reply" instead of "reply all", so sending it again.)
>
> I'll add "alias" references if no objections from other reviewers. 
> I'll probably add ELF symbol aliasing support with it, so hold on.
>
> We cannot remove kindLayoutBefore because doing it would break dead 
> stripping pass. We still need it for GC as GC needs backward references.
>
> To remove kindLayoutBefore, we have to modify dead striping pass so 
> that it creates back references internally from forward references and 
> use it while collecting dead objects. I think I'm going to make such 
> change, but it's going a bit large.
>
> Submitting this change first and then doing the next step in a 
> following patch would be better than merging the two together. 
> Incremental change is easier to bisect in case it would breaks 
> omething, and it's easy to understand for reviewers, too.
>
Do we have a flag to garbage collect atoms with lld in the current 
implementation ? If not removing kindLayoutBefore wouldnot affect 
anything right ?

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140327/03c4bd23/attachment.html>


More information about the llvm-commits mailing list