[PATCH] Optional support for dynamic Asan runtime

Yury Gribov tetra2005 at gmail.com
Thu Mar 27 06:11:13 PDT 2014



================
Comment at: lib/asan/asan_linux.cc:105
@@ +104,3 @@
+  if (dlsym(RTLD_DEFAULT, badsym)) {
+    Report("Your application is linked against "
+      "incompatible ASan runtimes.\n");
----------------
Yury Gribov wrote:
> Alexey Samsonov wrote:
> > Consider running tools/clang/tools/clang-format/clang-format-diff.py on your patch.
> Ok, good to know.
Are you sure the tool is usable? I see some strange changes like

+extern "C" __attribute__((
+    no_sanitize_address)) // Malloc may be called from dlsym in __asan_init
+void *malloc(size_t size) {

and misplaced comments.


http://llvm-reviews.chandlerc.com/D3042



More information about the llvm-commits mailing list