[llvm] r204899 - Fix for pr18931: Crash using integrated assembler with immediate arithmetic

Stepan Dyatkovskiy stpworld at narod.ru
Thu Mar 27 05:28:05 PDT 2014


Hi all!
My fix requires cancellation of error message that was committed by 
Jiangning Liu in r204898. In this commit he fixed exactly the same issue 
(pr18931) forbidding such kind of expressions with "invalid operand" 
error message.
I would like to ensure it's OK to apply patch with MCFixups, since we 
could be happy with such imm constructions then.
-Stepan.

Stepan Dyatkovskiy wrote:
> Hi Renato,
> Today I have tried to commit it and found some hidden bug:
> Under some machines "cmp r0, #(l2 - l1)" works fine, while under debian
> and friends it fails with "invalid operand" message. So I'm still in
> progress.
> -Stepan.
>
> Renato Golin wrote:
>> On 27 March 2014 07:49, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:
>>> Author: dyatkovskiy
>>> Date: Thu Mar 27 02:49:39 2014
>>> New Revision: 204899
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=204899&view=rev
>>> Log:
>>> Fix for pr18931: Crash using integrated assembler with immediate
>>> arithmetic
>>
>> Thanks Stepan/Rafael,
>>
>> We had a discussion in IRC and I completely forgot about the patch!
>>
>> cheers,
>> --renato
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list