[PATCH] Do not use layout-before to layout atoms.
chandlerc at google.com
Wed Mar 26 19:11:23 PDT 2014
On Wed, Mar 26, 2014 at 6:30 PM, Shankar Easwaram <shankarke at gmail.com>wrote:
> As I said before this functionality is critical for linker scripts and ELF.
Perhaps you can clarify how it is critical? I've not really been following
the discussion, but so far I don't see how these are strictly
interchangeable feature sets.
> If you do this in the elf writer that information would not be captured in
> the YAML or the native representation.
I don't see any discussion of the elf writer here. The claim seems to be
that layout-before and layout-after represent the same constraint, merely
expressed in two directions, and the code is simpler if it requires the
constraint to always be expressed in one direction.
> I am not convinced, as long as the functionality is not exercised by
> having a flag, I don't see why it impacts you at this time.
The complexity of the pass impacts the project, always. You cannot hide
complexity behind a flag. The question Rui is asking is why this complexity
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits