[PATCH] Add compiler support for dynamic Asan runtime

Alexey Samsonov samsonov at google.com
Wed Mar 26 12:00:46 PDT 2014

Comment at: lib/Driver/SanitizerArgs.cpp:174
@@ -172,1 +173,3 @@
+  if (NeedsAsan) {
+    AsanSharedRuntime = Args.hasArg(options::OPT_shared_libasan);
     AsanZeroBaseShadow =
Yury Gribov wrote:
> Alexey Samsonov wrote:
> > Why not define AsanSharedRuntime to true for llvm::Triple::Android here?
> Well, I thought about this. But my understanding was that SanitizerArgs is really about cmdline args, not about making control decisions.
Kind of... But we may think of it this way: "-shared-libasan argument is implied for Android". Otherwise, logic for dynamic runtime on Android shoudln't be different from dynamic runtime on Linux, there's no need to special-case it in control decisions.


More information about the llvm-commits mailing list