[PATCH] Fix MipsLongBranch pass to work when the code has inline assembly.

Sasa Stankovic Sasa.Stankovic at imgtec.com
Tue Mar 25 15:45:38 PDT 2014



================
Comment at: test/CodeGen/Mips/longbranch.ll:6
@@ -5,3 +9,5 @@
 
-define void @foo1(i32 %s) nounwind {
 entry:
----------------
Mark Seaborn wrote:
> Can you explain what's changing in the test case?  The changes to the test input look like they might be unnecessary, but I can't tell.  Could you make the test changes more minimal?
I simplified the fallthrough block (if.then) so that it has 2 bitcode instructions instead of 4, and has 3 assembly instructions instead of 4 (one less CHECK).  I also renamed the global variable g0 to x because in the assembly output there is a relocation %got(g0) and I thought that %got(x) would be more readable. I also renamed the test from foo1 to test1.


http://llvm-reviews.chandlerc.com/D3089



More information about the llvm-commits mailing list