[PATCH] AArch64_BE function argument passing for ARM ABI

Christian Pirker cpirker at a-bix.com
Tue Mar 25 11:05:08 PDT 2014



================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:1641-1642
@@ +1640,4 @@
+      uint32_t OpSize = Flags.isByVal() ? Flags.getByValSize()*8 :
+                                          VA.getLocVT().getSizeInBits();
+      OpSize = (OpSize + 7) / 8;
+      uint32_t BEAlign = 0;
----------------
Tim Northover wrote:
> Is this extra alignment step needed? I can't think of any types with a bitsize not a multiple of 8.
You are right, we simply copied line 1629.



http://llvm-reviews.chandlerc.com/D3176



More information about the llvm-commits mailing list