[PATCH][X86] Factor out new helper getPSHUFB

Adam Nemet anemet at apple.com
Tue Mar 25 10:57:22 PDT 2014


On Mar 24, 2014, at 11:43 PM, Nadav Rotem <nrotem at apple.com> wrote:

> +/// In vector type \p VT, return true if the element at index \p InputIdx
> +/// falls on a different 128-bit lane than \p OutputIdx.
> +static bool
> +ShuffleCrosses128bitLane(MVT VT, unsigned InputIdx, unsigned OutputIdx)
> +{
> +  unsigned EltSize = VT.getVectorElementType().getSizeInBits();
> 
> The braces should be on the same line. 

Ran it through clang-format-diff.

> Everything else LGTM. 

Thanks very much.  This is r204734 now.

Adam

> 
> 
> On Mar 24, 2014, at 10:52 PM, Adam Nemet <anemet at apple.com> wrote:
> 
>> <X86-Factor-out-new-helper-getPSHUFB.patch>
> 




More information about the llvm-commits mailing list