[llvm] r204703 - WinCOFF: Add support for -fdata-sections

[David Majnemer]

Sorry, my phone's autocorrect defeated me.  Internal symbols get entries in
the symbol table while private ones don't.

On Tuesday, March 25, 2014, David Majnemer <david.majnemer at gmail.com> wrote:

> Thinking about this some more, we are ok if t gets renamed so log as it
> gets into the symbol table.  Internal symbols don't get symbol table
> entries.
>
> On Tuesday, March 25, 2014, Rafael Espíndola <rafael.espindola at gmail.com<javascript:_e(%7B%7D,'cvml','rafael.espindola at gmail.com');>>
> wrote:
>
>> On 25 March 2014 02:14, David Majnemer <david.majnemer at gmail.com> wrote:
>> > Author: majnemer
>> > Date: Tue Mar 25 01:14:26 2014
>> > New Revision: 204703
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=204703&view=rev
>> > Log:
>> > WinCOFF: Add support for -fdata-sections
>> >
>> > This is a pretty straight forward translation for COFF, we just need to
>> > stick the data in a COMDAT section marked as
>> > IMAGE_COMDAT_SELECT_NODUPLICATES.
>> >
>> > N.B. We must be careful to avoid sticking entities with private linkage
>> > in COMDAT groups.  COFF is pretty hostile to the renaming of entities so
>> > we must be careful to disallow GlobalVariables with unstable names.
>>
>> Internal linkage can also be renamed. We do it in lib/Linker when
>> combining two files with different symbols with internal linkage.
>>
>> Cheers,
>> Rafael
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140325/f7558aff/attachment.html>